meta: consolidate email addresses for some individuals with multiple AUTHORS entries#39651
Closed
Trott wants to merge 3 commits intonodejs:masterfrom
Closed
meta: consolidate email addresses for some individuals with multiple AUTHORS entries#39651Trott wants to merge 3 commits intonodejs:masterfrom
Trott wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
meta
Member
|
You can keep the |
jasnell
approved these changes
Aug 3, 2021
tadjik1
reviewed
Aug 4, 2021
| Scott Blomquist <github@scott.blomqui.st> <sblom@microsoft.com> | ||
| Segu Riluvan <rilwan22@hotmail.com> <riluvan@gmail.com> | ||
| Sergey Kryzhanovsky <skryzhanovsky@gmail.com> <another@dhcp199-223-red.yandex.net> | ||
| Sergey Zelenov <mail@zelenov.su> <sergey.zelenov@getyourguide.com> |
Contributor
There was a problem hiding this comment.
Please keep only @zelenov.su, thanks!
Member
Author
There was a problem hiding this comment.
Please keep only @zelenov.su, thanks!
Thanks.
Just in case it's not clear what's going on here: This .mailmap file entry results in git and other tools treating all instances of the other email address as the same as the @zelenov.su address, which is why the other address is removed from the AUTHORS file in this pull request. The script that generates the AUTHORS file refers to .mailmap to figure out what email address to use for people that have more than one email in the git history.
So I think we're all set.
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in a1fac5b...54559b8 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #39651 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@szmarczak @tadjik1 @MarshallOfSound Please let me know if I guessed at the wrong email to keep.